feat!: Add message context to signature of intervention handler, add more to docs #4882
+81
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4882 +/- ##
==========================================
- Coverage 68.21% 68.18% -0.03%
==========================================
Files 158 158
Lines 9960 9967 +7
==========================================
+ Hits 6794 6796 +2
- Misses 3166 3171 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- python/packages/autogen-core/docs/src/user-guide/core-user-guide/cookbook/termination-with-intervention.ipynb: Evaluated as low risk
- python/packages/autogen-core/docs/src/user-guide/core-user-guide/cookbook/tool-use-with-intervention.ipynb: Evaluated as low risk
jackgerrits
changed the title
ekzhu
reviewed
Jan 4, 2025
| @@ -506,7 +515,14 @@ async def _process_next(self) -> None: | |||
| "intercept", handler.__class__.__name__, parent=message_envelope.metadata | |||
| ): | |||
| try: | |||
| temp_message = await handler.on_publish(message, sender=sender) | |||
| message_context = MessageContext( | |||
There was a problem hiding this comment.
Looks like some missing tests to make sure the runtime actually invokes the intervention handlers?
There was a problem hiding this comment.
The publish_message code path is missing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking:
on_publishandon_sendmethod in theInterventionHandlerclass to include amessage_contextparameter instead of anAgentIdparameter.Closes #4003
Related #4349