New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Tuple[type[ChatMessage], ...] with Sequence[type[ChatMessage]] #4857

Merged

ekzhu merged 1 commit into main from use-sequence

Dec 30, 2024

Collaborator

ekzhu commented Dec 30, 2024

Sequence is more consistent with the rest of the APIs and offers less surprise when it comes to callers.


          Replace Tuple[type[ChatMessage], ...] with Sequence[type[ChatMessage]]

dae86d2

ekzhu requested a review from jackgerrits

December 30, 2024 19:23

jackgerrits approved these changes

View reviewed changes

ekzhu merged commit 5ee2190 into main

50 checks passed

ekzhu deleted the use-sequence branch

December 30, 2024 19:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet