Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing model context attribute #4848

Merged
merged 4 commits into from
Dec 29, 2024

Conversation

Leon0402
Copy link
Contributor

@Leon0402 Leon0402 commented Dec 28, 2024

Why are these changes needed?

The case, where model context is not None was missing, leading to a runtime error. Probably makes sense generally to add a test for that functionality.

Related issue number

Checks

@gagb gagb requested a review from Copilot December 28, 2024 21:42

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thanks for the fix. It is a bug.

@ekzhu
Copy link
Collaborator

ekzhu commented Dec 29, 2024

Would be good to add a test.

@ekzhu ekzhu merged commit 23dbb6a into microsoft:main Dec 29, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants