Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(magentic-one): Remove redundant exception raising in update_ledger #4759

Merged
merged 3 commits into from
Dec 20, 2024
Merged

fix(magentic-one): Remove redundant exception raising in update_ledger #4759

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77e7c84
fix(magentic-one): Remove redundant exception raising in update_ledge…
Dec 19, 2024
f39ffe2
Merge branch 'main' into allow-parsing-retry
husseinmozannar Dec 20, 2024
950d32a
Remove unused exception variable 'e'
husseinmozannar Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/packages/autogen-magentic-one/src/autogen_magentic_one/agents/orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,14 +249,13 @@ async def update_ledger(self, cancellation_token: Optional[CancellationToken] =
if key_error:
continue
return ledger_dict
except json.JSONDecodeError as e:
except json.JSONDecodeError:
self.logger.info(
OrchestrationEvent(
f"{self.metadata['type']} (error)",
f"Failed to parse ledger information: {ledger_str}",
)
)
raise e

raise ValueError("Failed to parse ledger information after multiple retries.")

Expand Down
Loading