Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rysweet 4676 remove iagentruntime - collapse into iagentworker #4740

Merged

Conversation

rysweet
Copy link
Collaborator

@rysweet rysweet commented Dec 17, 2024

  • moves AgentId into Agent
  • Renames AgentRuntime to AgentMessenger (more accurate name)
  • Remove IAgentRuntime Interface
  • changes constructor of Agent to take IAgenWorker instead of IAgentRuntime

Why are these changes needed?

reduce code complexity and improve testability

Related issue number

closes #4676

Checks

@rysweet rysweet added the dotnet issues related to AutoGen.Net label Dec 17, 2024
@rysweet rysweet added this to the 0.4.0 milestone Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 31 out of 31 changed files in this pull request and generated no comments.

@rysweet rysweet linked an issue Dec 17, 2024 that may be closed by this pull request
@rysweet rysweet marked this pull request as draft December 17, 2024 17:33
@rysweet rysweet marked this pull request as ready for review December 17, 2024 18:17
@rysweet rysweet changed the title Rysweet 4676 remove iagentruntimecollapse into iagentworker Rysweet 4676 remove iagentruntime - collapse into iagentworker Dec 17, 2024
@rysweet rysweet requested a review from ramsoai December 17, 2024 18:18
@rysweet rysweet merged commit c1646f2 into main Dec 17, 2024
49 checks passed
@rysweet rysweet deleted the rysweet-4676-remove-iagentruntimecollapse-into-iagentworker branch December 17, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet issues related to AutoGen.Net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove IAgentRuntime/collapse into IAgentWorker
2 participants