Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "keep_first_message" to make sure messages are in correct order, #4653

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

milkmeat
Copy link

Why are these changes needed?

When "keep_first_message" is false, sometimes the truncated message list is in wrong order.
This fix inserts messages are in correct order,

Related issue number

#3178 (comment)

Checks

@ekzhu ekzhu linked an issue Dec 12, 2024 that may be closed by this pull request
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @WaelKarkoub FYI

@ekzhu ekzhu merged commit e90b9aa into microsoft:0.2 Dec 12, 2024
35 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MessageHistoryLimiter bug leading to incorrect order
2 participants