Add models.openai and tools.langchain namespaces #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lspinheiro
commented
Dec 7, 2024
python/packages/autogen-agentchat/src/autogen_agentchat/base/_handoff.py
Show resolved
Hide resolved
lspinheiro
changed the title
ekzhu
reviewed
Dec 8, 2024
ekzhu
reviewed
Dec 8, 2024
python/packages/autogen-core/docs/src/reference/python/autogen_ext.models.rst
Outdated
Show resolved
Hide resolved
|
@jackgerrits , there seems to be an test failing that is unrelated to the changes in the PR. I'm not sure what is the expected behavior of the code failing the test. Tagging for awareness FAILED tests/test_tools.py::test_get_typed_signature_string - AssertionError: assert (<class 'str'>, True) is str
+ where (<class 'str'>, True) = <Signature () -> (<class 'str'>, True)>.return_annotation |
lspinheiro
commented
Dec 8, 2024
python/packages/autogen-core/src/autogen_core/_pydantic_compat.py
Outdated
Show resolved
Hide resolved
jackgerrits
approved these changes
Dec 10, 2024
ekzhu
pushed a commit
that referenced
this pull request
Dec 10, 2024
* add models.openai namespace * refactor tools namespace * update lock file * revert pyproject changes * update docs and add cast * update ext models doc ref * increase underline * add reply models namespace * update imports * fix test * linting * fix missing conflicts * revert pydantic changes * rename to replay * replay * fix reply * Fix test * formatting * example --------- Co-authored-by: Leonardo Pinheiro <[email protected]> Co-authored-by: Jack Gerrits <[email protected]> Co-authored-by: Jack Gerrits <[email protected]>
eranco74
added a commit
to eranco74/autogen
that referenced
this pull request
Dec 10, 2024
Update the Python example in the readme to import OpenAIChatCompletionClient from the new path Currently, the example fails with this error: ImportError: cannot import name 'OpenAIChatCompletionClient' from 'autogen_ext.models' (unknown location) This change relates to: microsoft#4601
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Similar to agents and code executors, moving openai models to its own namespace.
Related issue number
Related to #4408
Checks