Skip to content

Conversation

@victordibia
Copy link
Collaborator

@victordibia victordibia commented Nov 26, 2024

Refactor AGS such that runs within sessions are persisted and displayed. Also support combinaiton of termination conditions in declarative spec for teams.

 "termination_condition": {
    "component_type": "termination",
    "termination_type": "CombinationTermination",
    "operator": "or",
    "conditions": [
      {
        "component_type": "termination",
        "termination_type": "TextMentionTermination",
        "text": "TERMINATE"
      },
      {
        "component_type": "termination",
        "termination_type": "MaxMessageTermination",
        "max_messages": 1
      }
    ]
  }

This PR also

  • adds ruff lint, ruff check and pytests to pyproject.toml (mypy and pyright in a separate effort)
  • uses socket connection to start run instead of previous http approach (fixes a serious multi-threading issue)

Why are these changes needed?

Related issue number

Checks

@victordibia victordibia marked this pull request as ready for review November 26, 2024 07:23
@husseinmozannar
Copy link
Contributor

Will test and review today, slight delay in the morning.

Copy link
Contributor

@husseinmozannar husseinmozannar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! Works quite well, had to delete my previous ags db as I kept getting errors, but nothing after that. Dual termination conditions also seems to work.

@victordibia victordibia merged commit fe96f7d into main Nov 26, 2024
42 checks passed
@victordibia victordibia deleted the ags_save_sessions branch November 26, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for combinations of termination conditions in AGS Support the ability to to save and review "sessions" in AGS

4 participants