Add token usage termination #4035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victordibia
reviewed
Nov 1, 2024
Collaborator
victordibia
left a comment
victordibia
left a comment
There was a problem hiding this comment.
Looking good.
Any thoughts on timeout/time based termination?
Contributor
Author
Good idea, let's have one |
victordibia
approved these changes
Nov 1, 2024
Collaborator
victordibia
left a comment
victordibia
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the fast turn around on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #4022
Requires #4028 to merge first