Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding function should always return a list of a list of vectors #3570

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

paubins2
Copy link
Contributor

@paubins2 paubins2 commented Sep 25, 2024

Why are these changes needed?

The PGVectorDB conforms to VectorDB, however it ignores the method signature for the embedding function.

Optional[Callable[[List[str]], List[List[float]]]]

Changing the embedding function to always expect a list of lists rather than a tensor.

Related issue number

Checks

Copy link

gitguardian bot commented Sep 25, 2024

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12853598 Triggered Generic High Entropy Secret 535eeae test/oai/test_utils.py View secret
10404693 Triggered Generic High Entropy Secret 535eeae test/oai/test_utils.py View secret
12853599 Triggered Generic High Entropy Secret 535eeae test/oai/test_utils.py View secret
10404694 Triggered Generic High Entropy Secret 535eeae test/oai/test_utils.py View secret
12853601 Triggered Generic High Entropy Secret 535eeae test/oai/test_utils.py View secret
10404696 Triggered Generic High Entropy Secret 535eeae test/oai/test_utils.py View secret
10422482 Triggered Generic High Entropy Secret 535eeae test/oai/test_utils.py View secret
12853602 Triggered Generic High Entropy Secret 535eeae test/oai/test_utils.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @paubins2 for the PR! mongodb.py has the same issue, would you like to fix that as well?

@thinkall thinkall added this pull request to the merge queue Sep 26, 2024
Merged via the queue into microsoft:main with commit 94064da Sep 26, 2024
36 of 48 checks passed
@paubins2 paubins2 deleted the pgvector_tensor_embeddding_fix branch September 26, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants