-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove api key validation #3569
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12853598 | Triggered | Generic High Entropy Secret | ed2bec7 | test/oai/test_utils.py | View secret |
10404693 | Triggered | Generic High Entropy Secret | ed2bec7 | test/oai/test_utils.py | View secret |
12853599 | Triggered | Generic High Entropy Secret | ed2bec7 | test/oai/test_utils.py | View secret |
10404694 | Triggered | Generic High Entropy Secret | ed2bec7 | test/oai/test_utils.py | View secret |
12853601 | Triggered | Generic High Entropy Secret | ed2bec7 | test/oai/test_utils.py | View secret |
10404696 | Triggered | Generic High Entropy Secret | ed2bec7 | test/oai/test_utils.py | View secret |
10422482 | Triggered | Generic High Entropy Secret | ed2bec7 | test/oai/test_utils.py | View secret |
12853602 | Triggered | Generic High Entropy Secret | ed2bec7 | test/oai/test_utils.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
+1, thanks @jackgerrits There is a case for autogen owning an improved developer UX here, but without a PR on the table and continued errors, I think this is the right move. Also, since OpenAPI doesn't provide any validation function or API, autogen will be chasing any changes that it seems OpenAI can and does make. |
Looks like this check is broken Don't you want the warning to only display if the instance |
You're totally right, thanks for catching that! |
Why are these changes needed?
It's not our business to check if keys are valid. If they are invalid, OpenAI or the given provider will provide the appropriate error message. The alternative of checking keys means we will exist in this permanent state of chasing key format changes which is not necessary or helpful and people are getting confusing warning messages due to false positives.
Related issue number
Closes #3345
Closes #3157
Closes #3544
Replaces #3330
Replaces #3494
Checks