-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use utf-8 encoding at subprocess.run() #3454
Merged
LittleLittleCloud
merged 3 commits into
microsoft:main
from
giorgossideris:localcommandlinecodeexecutor_utf8
Aug 30, 2024
Merged
Use utf-8 encoding at subprocess.run() #3454
LittleLittleCloud
merged 3 commits into
microsoft:main
from
giorgossideris:localcommandlinecodeexecutor_utf8
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@giorgossideris thanks for the fix. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3454 +/- ##
==========================================
+ Coverage 32.90% 37.46% +4.55%
==========================================
Files 94 96 +2
Lines 10235 10979 +744
Branches 2193 2534 +341
==========================================
+ Hits 3368 4113 +745
+ Misses 6580 6493 -87
- Partials 287 373 +86
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LittleLittleCloud
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use utf-8 encoding for local code execution
Closes #3453
Checks