Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookies from http session to web socket used by JupyterCodeExecutor #3312

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Add cookies from http session to web socket used by JupyterCodeExecutor #3312

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb14a67
feat: add cookies from http session to ws
timrbula Aug 6, 2024
01536dd
Merge branch 'main' into main
timrbula Aug 7, 2024
f9ff2e1
Merge branch 'main' into main
timrbula Aug 9, 2024
c5c96c0
Merge branch 'main' into main
timrbula Aug 21, 2024
f5f8dc2
Merge branch 'main' into main
jackgerrits Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion autogen/coding/jupyter/jupyter_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@ def _get_headers(self) -> Dict[str, str]:
return {}
return {"Authorization": f"token {self._connection_info.token}"}

def _get_cookies(self) -> str:
cookies = self._session.cookies.get_dict()
return "; ".join([f"{name}={value}" for name, value in cookies.items()])

def _get_api_base_url(self) -> str:
protocol = "https" if self._connection_info.use_https else "http"
port = f":{self._connection_info.port}" if self._connection_info.port else ""
Expand Down Expand Up @@ -87,7 +91,7 @@ def restart_kernel(self, kernel_id: str) -> None:

def get_kernel_client(self, kernel_id: str) -> JupyterKernelClient:
ws_url = f"{self._get_ws_base_url()}/api/kernels/{kernel_id}/channels"
ws = websocket.create_connection(ws_url, header=self._get_headers())
ws = websocket.create_connection(ws_url, header=self._get_headers(), cookie=self._get_cookies())
return JupyterKernelClient(ws)


Expand Down
Loading