Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Exception in a_generate_reply when function_call is None #3250

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

artero
Copy link
Contributor

@artero artero commented Jul 30, 2024

Why are these changes needed?

After executing generate_reply or a_generate_reply for an agent with a tool, the generated response (using the GPT-4o-mini model) contains "function_call"=None. If we call that function again, it causes an exception in the case of a_generate_reply (but not in generate_reply).

Related issue number

None

Checks

@umermansoor
Copy link
Contributor

lgtm

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I made a small suggestion. Could you create the PR from a branch in the upstream repo so that we can run the openai test?

autogen/agentchat/conversable_agent.py Outdated Show resolved Hide resolved
@artero artero force-pushed the function-call-none-reply branch from d571e97 to 123cc78 Compare August 26, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants