Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Avoid code scanning falsely identify #3199

Closed
wants to merge 4 commits into from

Conversation

Zizo-Vi
Copy link
Contributor

@Zizo-Vi Zizo-Vi commented Jul 24, 2024

Fix #3195

Checks

Copy link

gitguardian bot commented Jul 24, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10404695 Triggered Generic High Entropy Secret 0797d99 test/oai/test_utils.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Zizo-Vi Zizo-Vi changed the title [Test] avoid code scanning falsely identify [Test] Avoid code scanning falsely identify Jul 24, 2024
test/oai/test_utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Hk669 Hk669 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks more verbose. @afourney please let us know your thoughts on this.

@Hk669 Hk669 requested a review from afourney July 24, 2024 11:44
@Zizo-Vi
Copy link
Contributor Author

Zizo-Vi commented Jul 24, 2024

GitGuardian Security also check history commits? After I add new commit, security still failed at old commit id, why?

@sonichi sonichi enabled auto-merge July 25, 2024 18:14
auto-merge was automatically disabled July 26, 2024 01:09

Head branch was pushed to by a user without write access

@Zizo-Vi
Copy link
Contributor Author

Zizo-Vi commented Jul 26, 2024

Since GitGuardian also scan the history commit, I will close this PR and submit a new clean one.

@Zizo-Vi Zizo-Vi closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Placeholder keys cause false alarms on code-scanning tools
2 participants