-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded duplicate check for pydantic v1 since we are already checking that in the else block. #2467
Conversation
@microsoft-github-policy-service agree
@microsoft-github-policy-service agree |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
ef7c6d7
to
59487dd
Compare
59487dd
to
78214bf
Compare
gentle ping for review! /cc @davorrunje @ekzhu |
380c249
to
62ab993
Compare
62ab993
to
e67fb64
Compare
Thanks for spotting |
…checking that in the else block. (microsoft#2467) * Remove unneeded duplicate check for pydantic v1 since we are already in the else block. * fix formatting
Why are these changes needed?
Minor refactor to remove unneeded pydantic v1 check in the else block. No functional change.
Related issue number
Checks