-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Docker usage by enabling container reuse #2444
Conversation
@microsoft-github-policy-service agree |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but there are changes needed for CI to pass
Hi @akoumany - it's been a couple of weeks. We rebased this for you. If you are interested in bringing it forward please reopen and resolve the conflicts/green the CI. Thanks! |
Why are these changes needed?
These changes aim to enhance the efficiency of the DockerCommandLineCodeExecutor by allowing it to reuse existing Docker containers instead of starting a new one for each code execution.
This approach not only speeds up the code execution process by reducing the overhead associated with container setup and teardown but also aligns with sustainable resource usage practices.
Although these changes do not fully resolve #741, they incorporate the suggestion from bbence84 on the potential performance improvements from reusing containers.
Related issue number
Partially addresses #741 and somewhat related to #929
Checks