Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Docker usage by enabling container reuse #2444

Closed
wants to merge 1 commit into from

Conversation

akoumany
Copy link

Why are these changes needed?

These changes aim to enhance the efficiency of the DockerCommandLineCodeExecutor by allowing it to reuse existing Docker containers instead of starting a new one for each code execution.

This approach not only speeds up the code execution process by reducing the overhead associated with container setup and teardown but also aligns with sustainable resource usage practices.

Although these changes do not fully resolve #741, they incorporate the suggestion from bbence84 on the potential performance improvements from reusing containers.

Related issue number

Partially addresses #741 and somewhat related to #929

Checks

@akoumany
Copy link
Author

@microsoft-github-policy-service agree

Copy link

gitguardian bot commented Jul 20, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but there are changes needed for CI to pass

@ekzhu ekzhu changed the base branch from main to 0.2 October 2, 2024 18:30
@jackgerrits jackgerrits added the 0.2 Issues which are related to the pre 0.4 codebase label Oct 4, 2024
@rysweet rysweet added the awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster label Oct 10, 2024
@rysweet
Copy link
Collaborator

rysweet commented Oct 11, 2024

Hi @akoumany - it's been a couple of weeks. We rebased this for you. If you are interested in bringing it forward please reopen and resolve the conflicts/green the CI. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which are related to the pre 0.4 codebase awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker based code execution slow - reuse container / be able to specify requirements.txt up front
3 participants