Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AgentOptimizer test in CI #2380

Merged
merged 5 commits into from
Apr 16, 2024
Merged

add AgentOptimizer test in CI #2380

merged 5 commits into from
Apr 16, 2024

Conversation

skzhang1
Copy link
Collaborator

Why are these changes needed?

Related issue number

Closes #2353

Checks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.02%. Comparing base (4a44093) to head (f5edbe8).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2380      +/-   ##
==========================================
- Coverage   38.14%   37.02%   -1.12%     
==========================================
  Files          78       81       +3     
  Lines        7865     8084     +219     
  Branches     1683     1724      +41     
==========================================
- Hits         3000     2993       -7     
- Misses       4615     4840     +225     
- Partials      250      251       +1     
Flag Coverage Δ
unittests 37.02% <ø> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WaelKarkoub
Copy link
Contributor

--skip-docker

Thanks for the suggestion. Actually, the docker is optional.

I'm going through the AgentOptimizer implementation, and it seems like it's using docker to execute code. We might need to add a --skip-docker flag for those tests in case it wasn't installed

Thanks for the suggestion. Docker is not mandatory for AgentOptimizer. It is optional.

Moving the convo to this new PR. In test_record_conversation and test_step, they set up a user proxy with docker code execution

user_proxy = UserProxyAgent(
name="user_proxy",
human_input_mode="NEVER",
code_execution_config={
"work_dir": f"{here}/test_agent_scripts",
"use_docker": "python:3",
"timeout": 60,
},
max_consecutive_auto_reply=3,
)

user_proxy = UserProxyAgent(
name="user_proxy",
human_input_mode="NEVER",
code_execution_config={
"work_dir": f"{here}/test_agent_scripts",
"use_docker": "python:3",
"timeout": 60,
},
max_consecutive_auto_reply=3,
)

If they're not necessary, I would recommend removing them as they could cause the tests to be flaky.

@sonichi sonichi requested review from ekzhu and qingyun-wu April 14, 2024 00:53
AnonymousRepoSub added 2 commits April 15, 2024 09:42
@sonichi sonichi added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 0c5aed0 Apr 16, 2024
66 of 70 checks passed
@sonichi sonichi deleted the add_test_agentoptimizer branch April 16, 2024 05:15
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
* add test

* fix test

* fix

---------

Co-authored-by: AnonymousRepoSub <“[email protected]” >
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AgentOptimizer test is not included in the CI.
4 participants