Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add promptflow example #2369

Merged
merged 19 commits into from
Apr 17, 2024
Merged

add promptflow example #2369

merged 19 commits into from
Apr 17, 2024

Conversation

lordlinus
Copy link
Collaborator

Why are these changes needed?

This pull request introduces an example of how to incorporate Autogen within a workflow using PromptFlow. PromptFlow enables the creation, debugging, sharing, and iteration of executable flows, which can then be deployed as API endpoints. Additionally, it provides capabilities for evaluating and monitoring the flow to meet the requirements of enterprise environments.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.02%. Comparing base (4a44093) to head (5d54e72).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2369      +/-   ##
==========================================
- Coverage   38.14%   37.02%   -1.12%     
==========================================
  Files          78       81       +3     
  Lines        7865     8084     +219     
  Branches     1683     1724      +41     
==========================================
- Hits         3000     2993       -7     
- Misses       4615     4840     +225     
- Partials      250      251       +1     
Flag Coverage Δ
unittests 37.02% <ø> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A few things:

  1. Can you add some illustrations of what is PromptFlow and how this application integrates PromptFlow with AutoGen. Right now the README dives directly into "Chat flow" but many users do not know what this means.
  2. Can you add a blurb to the Ecosystem page for PromptFlow? You can find existing examples in website/docs/ecosystem.

Copy link

@d3ssy d3ssy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Would benefit from an explanation of the usage and role of Redis as well as alternatives to capture intermediate msgs during agent interactions.

@lordlinus
Copy link
Collaborator Author

Thanks for the PR! A few things:

  1. Can you add some illustrations of what is PromptFlow and how this application integrates PromptFlow with AutoGen. Right now the README dives directly into "Chat flow" but many users do not know what this means.
  2. Can you add a blurb to the Ecosystem page for PromptFlow? You can find existing examples in website/docs/ecosystem.

Thank you @ekzhu for your review, i have updated Readme. Can you please take a look again?

@sonichi sonichi requested a review from ekzhu April 13, 2024 15:00
@sonichi sonichi added the documentation Improvements or additions to documentation label Apr 13, 2024
@sonichi
Copy link
Contributor

sonichi commented Apr 16, 2024

@ekzhu the PR is blocked by your change request.

@sonichi sonichi enabled auto-merge April 16, 2024 04:48
@krishnashed
Copy link
Contributor

@lordlinus are you available on Autogen's discord? I would like to understand your code better by hopping on a call if possible. I'm facing some errors executing your code on my side. Maybe it's just some environment variables not being set or something trivial.

Copy link
Contributor

@krishnashed krishnashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error handling and Optional fields if any in YAML and JSON Schema

@lordlinus
Copy link
Collaborator Author

@lordlinus are you available on Autogen's discord? I would like to understand your code better by hopping on a call if possible. I'm facing some errors executing your code on my side. Maybe it's just some environment variables not being set or something trivial.

my Discord id ssk_sg can you please share yours to connect?

Copy link

@Josephrp Josephrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start to see more of these shared :

  • promptflow is great
  • semantic kernel is great
  • kernel memory is great

the documentation is 👌🏻very well done

auto-merge was automatically disabled April 17, 2024 13:27

Head branch was pushed to by a user without write access

@krishnashed
Copy link
Contributor

@lordlinus I see a nice to have feature which can be developed for easy installation and setup of Promptflow.

pip install pyautogen[promptflow]

This can be replicated to other integrations mentioned in as well #140

But we can take this up later too, I'm just suggesting.

@sonichi sonichi added this pull request to the merge queue Apr 17, 2024
Merged via the queue into microsoft:main with commit ba2cd4e Apr 17, 2024
24 checks passed
jayralencar pushed a commit to jayralencar/autogen that referenced this pull request May 28, 2024
* add promptflow example

* add promptflow example

* add newline and sort imports

* add newline and sort imports

* sort imports

* fix format errors

* update readme

* add ecosystem docs

* update broken link

* update broken link

* removing link to samples folder

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants