Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logger_factory.py #2328

Closed
wants to merge 9 commits into from
Closed

Update logger_factory.py #2328

wants to merge 9 commits into from

Conversation

wmwxwa
Copy link
Collaborator

@wmwxwa wmwxwa commented Apr 8, 2024

Why are these changes needed?

Adding Cosmos DB for logging

Related issue number

N/A

Checks

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the changes in this PR is better fit into #2329 ?

autogen/logger/logger_factory.py Outdated Show resolved Hide resolved
autogen/logger/logger_factory.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 46.75%. Comparing base (4a44093) to head (b9b3866).
Report is 15 commits behind head on main.

Files Patch % Lines
autogen/logger/logger_factory.py 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
+ Coverage   38.14%   46.75%   +8.60%     
==========================================
  Files          78       81       +3     
  Lines        7865     8085     +220     
  Branches     1683     1863     +180     
==========================================
+ Hits         3000     3780     +780     
+ Misses       4615     3983     -632     
- Partials      250      322      +72     
Flag Coverage Δ
unittests 46.67% <44.44%> (+8.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wmwxwa
Copy link
Collaborator Author

wmwxwa commented Apr 12, 2024

Maybe the changes in this PR is better fit into #2329 ?

Making the change through #2329. Deleting this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants