-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs related to Azure OpenAI's "model" #2315
Conversation
It uses the model as the deployment if the deployment is not specified. See the logic here: Line 397 in 94bff2d
I do agree this could be made clearer. Given the above logic do you think the proposed change should be updated? |
Head branch was pushed to by a user without write access
Shouldn't the logic raise an error if the deployment name is not specified as it is a mandatory field? |
@sonichi can you comment? As I understand it - often deployments are named the same as model names so this was simply a shortcut for this case. It may be too "magic" and leads to this sort of confusion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good catch!
bdd65e5
to
bcef3f5
Compare
634972c
to
380379f
Compare
* gitfu to get gh verified commits * revive lost point * fixed openai model related docs * newline EOF
Why are these changes needed?
The current documentation for using Autogen with Azure OpenAI contains an error. It states that the
model
parameter accepts values likegpt-4
orgpt-3.5-turbo
. However, in practice, this parameter should be set to the deployment name, which can be any user-defined string. This discrepancy in the documentation wasted a lot of time for me. Hopefully, this can save some time for others.Related issue number
Docs concern raised in #822
Checks
gpt-4
doesn't work