Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy llm_config to avoid external changes #2290

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

To avoid tools being added to all agents if a user passes the same dict, we take a copy internally to avoid changes leaking across.

Related issue number

Closes #2239

Checks

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingyun-wu qingyun-wu added this pull request to the merge queue Apr 5, 2024
Merged via the queue into main with commit 16b1db3 Apr 5, 2024
66 of 75 checks passed
@qingyun-wu qingyun-wu deleted the llm_config_copy branch April 5, 2024 14:13
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: autogen.agentchat.register_function adds to all Agents instead of single
2 participants