Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore protobuf generated files in CAP #2215

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

rajan-chari
Copy link
Contributor

@rajan-chari rajan-chari commented Mar 30, 2024

Why are these changes needed?

Protobuf is an industry standard format for publishing and receiving messages. CAP uses these messages in the message bus.
protoc generates files that bind the message to python. These files are not meant to be fixed by hand.

pre-commit ruff checks fails on these files.

Related issue number

Closes #2190

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.55%. Comparing base (8cb5c14) to head (38c35ea).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2215      +/-   ##
==========================================
+ Coverage   37.53%   37.55%   +0.02%     
==========================================
  Files          77       77              
  Lines        7710     7719       +9     
  Branches     1655     1657       +2     
==========================================
+ Hits         2894     2899       +5     
- Misses       4573     4574       +1     
- Partials      243      246       +3     
Flag Coverage Δ
unittests 37.54% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajan-chari rajan-chari requested a review from davorrunje March 30, 2024 18:59
@sonichi sonichi added this pull request to the merge queue Mar 30, 2024
Merged via the queue into microsoft:main with commit 83aef3a Mar 30, 2024
24 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: pre-commit checks are failing for protobuf generated files
4 participants