-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoGenBench: Handle Ctrl-C more gracefully. #2174
Conversation
Prints the version of AutoGenBench from the command line, closing i1458
Initial PR: Add gitignore and improve template detection
…t can be found (experimental).
…8e68-6d28256631b4'
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2174 +/- ##
==========================================
+ Coverage 37.36% 37.97% +0.61%
==========================================
Files 74 75 +1
Lines 7481 7587 +106
Branches 1617 1634 +17
==========================================
+ Hits 2795 2881 +86
- Misses 4445 4463 +18
- Partials 241 243 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Prints the version of AutoGenBench from the command line, closing i1458 * Added autogenbench version to timestamp.txt * Attempting to fix formatting. * Add a gitignore for autogenbench * Generalize to read all template dirs from Templates * AutoGenBench logs telemetry when available. * Remove spaces if present from template names. * Bump version. * Fixed formatting. * Allow native warning to be skipped. Mount autogen repo in Docker if it can be found (experimental). * Native execution now occurs in a venv. * Bump version. * Fixed a prompt escaping bug evident in GAIA task '6f37996b-2ac7-44b0-8e68-6d28256631b4' * Updated all scenarios to use template discovery. * Update with main version of runtime_logging. * Better handling of Ctrl-C and cleanup of unused containers. * Even stronger hinting that containers should be removed. --------- Co-authored-by: gagb <[email protected]>
Why are these changes needed?
Previously hitting Ctrl-C during an AutoGenBench run, when operating in Docker, would result in the Docker container being left behind (and possibly still running in some cases). This PR catches the interrupt, and exits more gracefully if possible.
Related issue number
Checks