-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the problem config_list_from_dotenv() can't correctly get other p… #2172
fix the problem config_list_from_dotenv() can't correctly get other p… #2172
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2172 +/- ##
===========================================
+ Coverage 37.54% 49.51% +11.96%
===========================================
Files 77 77
Lines 7711 7711
Branches 1655 1791 +136
===========================================
+ Hits 2895 3818 +923
+ Misses 4573 3577 -996
- Partials 243 316 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on noticing that edge case, let me know what you think of the comment below 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
microsoft#2172) * fix the problem config_list_from_dotenv() can't correctly get other params * Update openai_utils.py --------- Co-authored-by: Aaron <[email protected]> Co-authored-by: Chi Wang <[email protected]>
Why are these changes needed?
As you can see, when I was testing the code shown below, I found that I couldn't get the configuration information saved in
.env
correctly withconfig_list_from_dotenv().
The version of pyautogen is 0.2.20, which is the latest release.And my
.env
is like this:Then I realized that
get_config()
was using the wrong parameter to get the configuration, and changed it to get the other parameters correctly.After the modification, the code works fine.
Related issue number
Checks