Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #2170

Closed
wants to merge 4 commits into from
Closed

Update package.json #2170

wants to merge 4 commits into from

Conversation

jonmadison
Copy link

@jonmadison jonmadison commented Mar 27, 2024

Added scope to package name to play nicely worldwide. :)

#2214

Why are these changes needed?

Related issue number

Checks

Added scope to package name to play nicely worldwide. :)
@jonmadison
Copy link
Author

added scoping to this package; borrowed from existing microsoft project convention (office-js).

@@ -1,5 +1,5 @@
{
"name": "website",
"name": "@microsoft/autogen-website",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this package is not published can we just remove the name and version?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this is package is not published. Also suggest instead of @microsoft/autogen-website just autogen-website

Copy link

gitguardian bot commented Jul 20, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10404662 Triggered Generic CLI Secret c6672e0 .github/workflows/dotnet-release.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@gagb gagb requested review from ekzhu, jackgerrits and gagb and removed request for ekzhu August 28, 2024 00:19
@gagb gagb requested review from jackgerrits and marklysze and removed request for jackgerrits August 28, 2024 00:37
@gagb gagb requested a review from victordibia August 28, 2024 06:29
@jackgerrits
Copy link
Member

Closing since we haven't heard from you - please feel free to reopen if you'd like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants