Multiline docstrings fix #2130

sharsha315 · 2024-03-23T14:47:11Z

This PR focuses on formatting multiline docstrings using the Google style guide for consistency and clarity across the project. The changes made to autogen/autogen/agentchat/contrib/retrieve_user_proxy_agent.py and autogen/autogen/agentchat/contrib/retrieve_user_proxy_agent.py partially address the issue #2048, as many files in the project require similar formatting adjustments. Please review and merge accordingly.

Why are these changes needed?

Added a first single line on RetrieveUserProxyAgent. The short definition line was taken by referring [here.]https://microsoft.github.io/autogen/blog/2023/10/18/RetrieveChat#introduction)
Formatted Docstrings in the RetrieveUserProxyAgent Class in autogen/autogen/agentchat/contrib/retrieve_user_proxy_agent.py file.
Formatted docstrings for the initiate_chats functiion of ChatResult class in autogen/agentchat/chat.py file.

Related issue number

#2048

Checks

I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
I've added tests (if relevant) corresponding to the changes introduced in this PR.
I've made sure all auto checks have passed.

…nd Added first single line for the class RetrieveUserProxyAgent.

…tResult class in autogen/agentchat/chat.py

sharsha315 · 2024-03-23T17:47:05Z

@microsoft-github-policy-service agree

…

On Sat, Mar 23, 2024 at 10:49 PM microsoft-github-policy-service[bot] < ***@***.***> wrote: @sharsha315 <https://github.com/sharsha315> please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. @microsoft-github-policy-service agree [company="{your company}"] Options: - (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer. @microsoft-github-policy-service agree - (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer. @microsoft-github-policy-service agree company="Microsoft" Contributor License Agreement Contribution License Agreement This Contribution License Agreement (*“Agreement”*) is agreed to by the party signing below (*“You”*), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below. 1. *Definitions*. *“Code”* means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. *“Project”* means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.org). *“Submit”* is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Submission.” *“Submission”* means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation. 2. *Your Submission*. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project. 3. *Originality of Work*. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase “Submission containing materials of a third party:” followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project’s written guidelines concerning Submissions. 4. *Your Employer*. References to “employer” in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term “You” in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions. 5. *Licenses*. - *Copyright License*. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties. - *Patent License*. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project. - *Other Rights Reserved*. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise. 1. *Representations and Warranties*. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE. 2. *Notice to Microsoft*. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect. 3. *Information about Submissions*. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission. 4. *Governing Law/Jurisdiction*. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens. 5. *Entire Agreement/Assignment*. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft. — Reply to this email directly, view it on GitHub <#2130 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALGUCKWQPDT3UA574KUAREDYZW2TVAVCNFSM6AAAAABFEWS3H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGU2TEMZXHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ekzhu · 2024-03-23T19:27:28Z

Have you tried to build the website locally and see what the results look like in the API docs? See contrib docs for building website locally. You can take a screenshot of that much appreciated

gagb · 2024-03-23T21:58:49Z

Have you tried to build the website locally and see what the results look like in the API docs? See contrib docs for building website locally. You can take a screenshot of that much appreciated

Thank you for the PR!

To add to what Eric said. Also might wanna check if the doc string renders correctly in the IDE. Before/after screenshots would be nice. I think @jackgerrits recommended the google convention? It would be nice to update the description to say which convention you used.

Also closing #2048 would require edits to a lot of files.

sharsha315 · 2024-03-24T08:09:15Z

Have you tried to build the website locally and see what the results look like in the API docs? See contrib docs for building website locally. You can take a screenshot of that much appreciated

Thank you for the PR!

To add to what Eric said. Also might wanna check if the doc string renders correctly in the IDE. Before/after screenshots would be nice. I think @jackgerrits recommended the google convention? It would be nice to update the description to say which convention you used.

Also closing #2048 would require edits to a lot of files.

Thanks for the feedback! I initially focused on fixing the two files mentioned in the issue. You said it would require edits to a lot of files, could you please clarify which files I'm allowed to change and which files allowed not to change. Also, I'll carefully look into your recommendation and update the description accordingly. Your guidance would be greatly appreciated, so that I can continue working on it. Thanks again.

codecov-commenter · 2024-03-24T09:01:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.94%. Comparing base (6c3d779) to head (227b063).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2130   +/-   ##
=======================================
  Coverage   37.94%   37.94%           
=======================================
  Files          77       77           
  Lines        7784     7784           
  Branches     1667     1667           
=======================================
  Hits         2954     2954           
  Misses       4580     4580           
  Partials      250      250

Flag	Coverage Δ
unittests	`37.93% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thinkall

Thank you @sharsha315 for the contribution!
Looks like you're using some tools to break the lines into length of 80. Could you share which tool is it? Maybe we can add it to the pre-commit tool and set the length to be 120 which is the same as the code length. And can we config the tool to not break a link?

autogen/agentchat/chat.py

gagb · 2024-03-25T06:58:08Z

Have you tried to build the website locally and see what the results look like in the API docs? See contrib docs for building website locally. You can take a screenshot of that much appreciated

Thank you for the PR!
To add to what Eric said. Also might wanna check if the doc string renders correctly in the IDE. Before/after screenshots would be nice. I think @jackgerrits recommended the google convention? It would be nice to update the description to say which convention you used.
Also closing #2048 would require edits to a lot of files.

Thanks for the feedback! I initially focused on fixing the two files mentioned in the issue. You said it would require edits to a lot of files, could you please clarify which files I'm allowed to change and which files allowed not to change. Also, I'll carefully look into your recommendation and update the description accordingly. Your guidance would be greatly appreciated, so that I can continue working on it. Thanks again.

I think we want to improve consistency across every files in library e.g., files in the main module autogen

I suggest that you try to get fixes to these two files reviewed but say that this PR only partially addresses the issue. Once multiple reviewers are happy, get this PR merged. Then create a new issue with a task list/plan and one-by-one make new PRs to improve a small set of files. This might help you contribute gradually without introducing massive merge conflicts (since module files might change). @jackgerrits and @ekzhu please add if I missed anything.

sharsha315 · 2024-03-26T09:24:03Z

Have you tried to build the website locally and see what the results look like in the API docs? See contrib docs for building website locally. You can take a screenshot of that much appreciated

Thank you for the PR!
To add to what Eric said. Also might wanna check if the doc string renders correctly in the IDE. Before/after screenshots would be nice. I think @jackgerrits recommended the google convention? It would be nice to update the description to say which convention you used.
Also closing #2048 would require edits to a lot of files.

Thanks for the feedback! I initially focused on fixing the two files mentioned in the issue. You said it would require edits to a lot of files, could you please clarify which files I'm allowed to change and which files allowed not to change. Also, I'll carefully look into your recommendation and update the description accordingly. Your guidance would be greatly appreciated, so that I can continue working on it. Thanks again.

I think we want to improve consistency across every files in library e.g., files in the main module autogen

I suggest that you try to get fixes to these two files reviewed but say that this PR only partially addresses the issue. Once multiple reviewers are happy, get this PR merged. Then create a new issue with a task list/plan and one-by-one make new PRs to improve a small set of files. This might help you contribute gradually without introducing massive merge conflicts (since module files might change). @jackgerrits and @ekzhu please add if I missed anything.

Thanks for clarifying the approach and providing guidance on how to proceed. I am on it.

* Add vision capability * Configurate: description_prompt * Print warning instead of raising issues for type * Skip vision capability test if dependencies not installed * Append "vision" to agent's system message when enabled VisionCapability * GPT-4V notebook update with ConversableAgent * Clean GPT-4V notebook * Add vision capability test to workflow * Lint import * Update system message for vision capability * Add a `custom_caption_func` to VisionCapability * Add custom function example for vision capability * Skip test Vision capability custom func * GPT-4V notebook metadata to website * Remove redundant files * The custom caption function takes more inputs now * Add a more complex example of custom caption func * Remove trailing space --------- Co-authored-by: Chi Wang <[email protected]>

sharsha315 · 2024-04-01T13:44:51Z

Hi @thinkall, just following up on my PR. Would appreciate any feedback or updates on its status. Thanks!

autogen/agentchat/chat.py

RohitRathore1

LGTM

RohitRathore1 · 2024-04-02T09:44:30Z

@sharsha315 It would be nice if you can address this comment by @gagb

Also closing #2048 would require edits to a lot of files.

Because it will allow to close that issue if you can make the changes.

sharsha315 · 2024-04-02T10:23:12Z

@sharsha315 It would be nice if you can address this comment by @gagb

Also closing #2048 would require edits to a lot of files.

Because it will allow to close that issue if you can make the changes.

I was earlier suggested by @gagb , to first get reviewed this two files but as this partially addresses the issue, after multiple reviewers are happy, get this PR merged. Then create a new issue with a task list/plan and one-by-one make new PRs to improve a small set of files. This might help you contribute gradually without introducing massive merge conflicts (since module files might change).

jackgerrits

Could you please update the description so that the relevant issue is not closed by this PR as there are other files to be edited too

sharsha315 · 2024-04-02T14:31:25Z

Could you please update the description so that the relevant issue is not closed by this PR as there are other files to be edited too

Hi @jackgerrits, I have updated the description, please review and provide feedback, any other information needs to be updated. Thank You.

* DOC FIX - Formatted Docstrings for the retrieve_user_proxy_agent.py and Added first single line for the class RetrieveUserProxyAgent. * DOC FIX - Formatted Docstrings for theinitiate_chats functiion of ChatResult class in autogen/agentchat/chat.py * Add vision capability (microsoft#2025) * Add vision capability * Configurate: description_prompt * Print warning instead of raising issues for type * Skip vision capability test if dependencies not installed * Append "vision" to agent's system message when enabled VisionCapability * GPT-4V notebook update with ConversableAgent * Clean GPT-4V notebook * Add vision capability test to workflow * Lint import * Update system message for vision capability * Add a `custom_caption_func` to VisionCapability * Add custom function example for vision capability * Skip test Vision capability custom func * GPT-4V notebook metadata to website * Remove redundant files * The custom caption function takes more inputs now * Add a more complex example of custom caption func * Remove trailing space --------- Co-authored-by: Chi Wang <[email protected]> * Native tool call support for Mistral AI API and topic notebook. (microsoft#2135) * Support for Mistral AI API and topic notebook. * formatting * formatting * New conversational chess notebook using nested chats and tool use (microsoft#2137) * add chess notebook * update * update * Update notebook with figure * Add example link * redirect * Clean up example format * address gagan's comments * update references * fix links * add webarena in samples (microsoft#2114) * add webarena in samples/tools * Update samples/tools/webarena/README.md Co-authored-by: gagb <[email protected]> * Update samples/tools/webarena/README.md Co-authored-by: gagb <[email protected]> * Update samples/tools/webarena/README.md Co-authored-by: gagb <[email protected]> * update installation instructions * black formatting * Update README.md --------- Co-authored-by: gagb <[email protected]> Co-authored-by: Eric Zhu <[email protected]> * context to kwargs (microsoft#2064) * context to kwargs * add tag * add test * text to kwargs --------- Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Chi Wang <[email protected]> * Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /website (microsoft#2131) Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Eric Zhu <[email protected]> * Parse Any HTML-esh Style Tags (microsoft#2046) * tried implementing my own regex * improves tests * finally works * removes prints * fixed test * adds start and end * delete unused imports * refactored to use new tool * significantly improved algo * tag content -> tag attr * fix tests + adds new field * return full match * return remove start and end * update docstrings * update docstrings * update docstrings --------- Co-authored-by: Beibin Li <[email protected]> Co-authored-by: Chi Wang <[email protected]> * Integrate AgentOptimizer (microsoft#1767) * draft agent optimizer * refactor * remove * change openai config interface * notebook * update blog * add test * clean up * redir * update * update interface * change model name * move to contrib * Update autogen/agentchat/contrib/agent_optimizer.py Co-authored-by: Jack Gerrits <[email protected]> --------- Co-authored-by: “skzhang1” <“[email protected]”> Co-authored-by: Beibin Li <[email protected]> Co-authored-by: Jieyu Zhang <[email protected]> Co-authored-by: Jack Gerrits <[email protected]> * Introducing IOStream protocol and adding support for websockets (microsoft#1551) * Introducing IOStream * bug fixing * polishing * refactoring * refactoring * refactoring * wip: async tests * websockets added * wip * merge with main * notebook added * FastAPI example added * wip * merge * getter/setter to iostream added * website/blog/2024-03-03-AutoGen-Update/img/dalle_gpt4v.png: convert to Git LFS * website/blog/2024-03-03-AutoGen-Update/img/gaia.png: convert to Git LFS * website/blog/2024-03-03-AutoGen-Update/img/teach.png: convert to Git LFS * add SSL support * wip * wip * exception handling added to on_connect() * refactoring: default iostream is being set in a context manager * test fix * polishing * polishing * polishing * fixed bug with new thread * polishing * a bit of refactoring and docs added * notebook added to docs * type checking added to CI * CI fix * CI fix * CI fix * polishing * obsolete todo comment removed * fixed precommit error --------- Co-authored-by: Eric Zhu <[email protected]> * [CAP] [Feature] Get list of actors from directory service. (microsoft#2073) * Search directory for list of actors using regex '.*' gets all actors * docs changes * pre-commit fixes * Use ActorInfo from protobuf * pre-commit * Added zmq tests to work on removing sleeps * minor refactor of zmq tests * 1) Change DirSvr to user Broker. 2) Add req-router to broker 3) In ActorConnector use handshake and req/resp to remove sleep * 1) Change DirSvr to user Broker. 2) Add req-router to broker 3) In ActorConnector use handshake and req/resp to remove sleep * move socket creation to thread with recv * move socket creation to thread with recv * Better logging for DirectorySvc * better logging for directory svc * Use logging config * Start removing sleeps * pre-commit * Cleanup monitor socket * Mark cache as a protocol and update type hints to reflect (microsoft#2168) * Mark cache as a protocl and update type hints to reflect * int * undo init change modified: autogen/agentchat/chat.py * fix(): fix word spelling errors (microsoft#2171) * Implement User Defined Functions for Local CLI Executor (microsoft#2102) * Implement user defined functions feature for local cli exec, add docs * add tests, update docs * fixes * fix test * add pandas test dep * install test * provide template as func * formatting * undo change * address comments * add test deps * formatting * test only in 1 env * formatting * remove test for local only --------- Co-authored-by: Eric Zhu <[email protected]> * simplify getting-started; update news (microsoft#2175) * simplify getting-started; update news * bug fix * update (microsoft#2178) Co-authored-by: AnonymousRepoSub <“[email protected]” > * Fix formatting of admonitions in udf docs (microsoft#2188) * Fix iostream on new thread (microsoft#2181) * fixed get_stream in new thread by introducing a global default * fixed get_stream in new thread by introducing a global default --------- Co-authored-by: Chi Wang <[email protected]> * Add link for rendering notebooks docs on website (microsoft#2191) * Transform Messages Capability (microsoft#1923) * wip * Adds docstrings * fixed spellings * wip * fixed errors * better class names * adds tests * added tests to workflow * improved token counting * improved notebook * improved token counting in test * improved docstrings * fix inconsistencies * changed by mistake * fixed docstring * fixed details * improves tests + adds openai contrib test * fix spelling oai contrib test * clearer docstrings * remove repeated docstr * improved notebook * adds metadata to notebook * Improve outline and description (microsoft#2125) * better dir structure * clip max tokens to allowed tokens * more accurate comments/docstrs * add deperecation warning * fix front matter desc * add deperecation warning notebook * undo local notebook settings changes * format notebook * format workflow --------- Co-authored-by: gagb <[email protected]> * Bump express from 4.18.2 to 4.19.2 in /website (microsoft#2157) Bumps [express](https://github.com/expressjs/express) from 4.18.2 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.18.2...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add clarity analytics (microsoft#2201) * Docstring formatting fix: Standardize docstrings to adhere to Google style guide, ensuring consistency and clarity. and also fixed the broken link for autogen/agentchat/chat.py * Docstring fix: Reformattted docstrings to adhere to Google style guide, nsuring consistency and clarity. For agentchat/contrib/retrieve_user_proxy_agent.py file * Fixed Pre-Commit Error, Trailing spaces on agentchat/chat.py * Fixed Pre-Commit Error, Trailing spaces on agentchat/chat.py --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Li Jiang <[email protected]> Co-authored-by: Beibin Li <[email protected]> Co-authored-by: Chi Wang <[email protected]> Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: olgavrou <[email protected]> Co-authored-by: gagb <[email protected]> Co-authored-by: Qingyun Wu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wael Karkoub <[email protected]> Co-authored-by: Shaokun Zhang <[email protected]> Co-authored-by: “skzhang1” <“[email protected]”> Co-authored-by: Jieyu Zhang <[email protected]> Co-authored-by: Jack Gerrits <[email protected]> Co-authored-by: Davor Runje <[email protected]> Co-authored-by: Rajan <[email protected]> Co-authored-by: calm <[email protected]> Co-authored-by: AnonymousRepoSub <“[email protected]” >

sharsha315 added 2 commits March 23, 2024 14:08

DOC FIX - Formatted Docstrings for the retrieve_user_proxy_agent.py a…

b441533

…nd Added first single line for the class RetrieveUserProxyAgent.

DOC FIX - Formatted Docstrings for theinitiate_chats functiion of Cha…

9a03544

…tResult class in autogen/agentchat/chat.py

RohitRathore1 assigned ekzhu, jackgerrits, qingyun-wu, gagb and RohitRathore1 and unassigned ekzhu, jackgerrits, qingyun-wu, gagb and RohitRathore1 Mar 23, 2024

RohitRathore1 requested review from ekzhu, thinkall, afourney, sonichi, jackgerrits, gagb and RohitRathore1 March 23, 2024 17:20

Merge branch 'main' into multiline-docstrings-fix

a110a1f

thinkall reviewed Mar 24, 2024

View reviewed changes

autogen/agentchat/chat.py Outdated Show resolved Hide resolved

ekzhu added the documentation Improvements or additions to documentation label Mar 25, 2024

sonichi requested a review from Josephrp April 1, 2024 04:34

sonichi enabled auto-merge April 1, 2024 13:57

Merge branch 'main' into multiline-docstrings-fix

ae042fb

thinkall approved these changes Apr 2, 2024

View reviewed changes

Josephrp reviewed Apr 2, 2024

View reviewed changes

autogen/agentchat/chat.py Show resolved Hide resolved

Josephrp approved these changes Apr 2, 2024

View reviewed changes

RohitRathore1 approved these changes Apr 2, 2024

View reviewed changes

jackgerrits approved these changes Apr 2, 2024

View reviewed changes

ekzhu added 2 commits April 2, 2024 10:56

Merge branch 'main' into multiline-docstrings-fix

e132fcb

Merge branch 'main' into multiline-docstrings-fix

227b063

sonichi added this pull request to the merge queue Apr 3, 2024

Merged via the queue into microsoft:main with commit 2053dd9 Apr 3, 2024
30 of 72 checks passed

ekzhu had a problem deploying to openai1 May 3, 2024 01:51 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiline docstrings fix #2130

Multiline docstrings fix #2130

sharsha315 commented Mar 23, 2024 •

edited by jackgerrits

Loading

sharsha315 commented Mar 23, 2024 via email

ekzhu commented Mar 23, 2024 •

edited

Loading

gagb commented Mar 23, 2024 •

edited

Loading

sharsha315 commented Mar 24, 2024

codecov-commenter commented Mar 24, 2024 •

edited

Loading

thinkall left a comment

gagb commented Mar 25, 2024

sharsha315 commented Mar 26, 2024

sharsha315 commented Apr 1, 2024

RohitRathore1 left a comment

RohitRathore1 commented Apr 2, 2024 •

edited

Loading

sharsha315 commented Apr 2, 2024 •

edited

Loading

jackgerrits left a comment

sharsha315 commented Apr 2, 2024

Multiline docstrings fix #2130

Multiline docstrings fix #2130

Conversation

sharsha315 commented Mar 23, 2024 • edited by jackgerrits Loading

Why are these changes needed?

Related issue number

Checks

sharsha315 commented Mar 23, 2024 via email

ekzhu commented Mar 23, 2024 • edited Loading

gagb commented Mar 23, 2024 • edited Loading

sharsha315 commented Mar 24, 2024

codecov-commenter commented Mar 24, 2024 • edited Loading

Codecov Report

thinkall left a comment

Choose a reason for hiding this comment

gagb commented Mar 25, 2024

sharsha315 commented Mar 26, 2024

sharsha315 commented Apr 1, 2024

RohitRathore1 left a comment

Choose a reason for hiding this comment

RohitRathore1 commented Apr 2, 2024 • edited Loading

sharsha315 commented Apr 2, 2024 • edited Loading

jackgerrits left a comment

Choose a reason for hiding this comment

sharsha315 commented Apr 2, 2024

sharsha315 commented Mar 23, 2024 •

edited by jackgerrits

Loading

ekzhu commented Mar 23, 2024 •

edited

Loading

gagb commented Mar 23, 2024 •

edited

Loading

codecov-commenter commented Mar 24, 2024 •

edited

Loading

RohitRathore1 commented Apr 2, 2024 •

edited

Loading

sharsha315 commented Apr 2, 2024 •

edited

Loading