test

[LittleLittleCloud]

Why are these changes needed?

Related issue number

Checks

• I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
• I've added tests (if relevant) corresponding to the changes introduced in this PR.
• I've made sure all auto checks have passed.

[codecov-commenter]

Codecov Report

Merging #21 (0a42469) into main (8e9cda7) will increase coverage by 3.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   32.12%   35.16%   +3.04%     
==========================================
  Files          16       17       +1     
  Lines        1958     1965       +7     
  Branches      432      432              
==========================================
+ Hits          629      691      +62     
+ Misses       1276     1223      -53     
+ Partials       53       51       -2     

Flag	Coverage Δ
unittests	35.11% <ø> (+2.98%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

[qingyun-wu]

Can you by the way, remove this line

# %pip install --quiet flaml"[autogen]"~=2.1.0

from the first code block of this notebook: https://github.com/microsoft/autogen/blob/main/notebook/agentchat_teaching.ipynb

[sonichi]

Can you by the way, remove this line

# %pip install --quiet flaml"[autogen]"~=2.1.0

from the first code block of this notebook: https://github.com/microsoft/autogen/blob/main/notebook/agentchat_teaching.ipynb

I'll make that change.

[sonichi]

This PR doesn't trigger OpenAI test. Do you know how to trigger it?

[LittleLittleCloud]

pull_request_target event runs in the context of the base repository of the pull request, rather than in the merge commit. This is designed specifically for the purpose of providing a safe execution environment for workflows that originate from forks.

That's why, you probably need to merge it to main so the rest of PR will be able to trigger that workflow

That actually reminds me that I forget to checkout to the merge commit to run the test. Can you not merge this PR until I add that checkout step?

[sonichi]

pull_request_target event runs in the context of the base repository of the pull request, rather than in the merge commit. This is designed specifically for the purpose of providing a safe execution environment for workflows that originate from forks.

That's why, you probably need to merge it to main so the rest of PR will be able to trigger that workflow

That actually reminds me that I forget to checkout to the merge commit to run the test. Can you not merge this PR until I add that checkout step?

The PR should trigger the test based on the rules. Do you know why it doesn't trigger? I'd like to test it before merging.

[LittleLittleCloud]

@sonichi

The workflow with pull_request_target needs to be merged to the base repo for testing. It won't be triggered by a pull request.

This is because pull_request_target event runs in the context of the base repository of the pull request, rather than in the merge commit. For example, the base repository of this pull request is microsoft:main, and there's no code change detected. Therefore, the openai workflow won't be triggerd.

In order to run the test, we need to checkout to the merge commit so the change from pull request will be applied. I haven't add the step to checkout to merge commit in openai workflow yet, so please don't merge this PR

[sonichi]

Could you make this a draft until it's ready?