-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy to pre-commit #2068
Add mypy to pre-commit #2068
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
===========================================
+ Coverage 36.88% 48.32% +11.44%
===========================================
Files 68 68
Lines 7062 7062
Branches 1540 1668 +128
===========================================
+ Hits 2605 3413 +808
+ Misses 4228 3360 -868
- Partials 229 289 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sonichi no need, it is automatically setup through existing pre-commit hook |
* Add mypy check in pre-commit * Add mypy check in pre-commit * bug fix * CI fix * add python version matrix for checking types in CI * added 3.12 to CI --------- Co-authored-by: Eric Zhu <[email protected]>
Why are these changes needed?
Ideally, pre-commit hook should check types for files that will be checked by mypy in CI. This PR:
As a consequence, we can run mypy locally on a subset of files as specified in pyproject.toml by simply executing the following command:
Related issue number
Checks