fix test_human_input #2063
Merged
fix test_human_input #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
==========================================
+ Coverage 36.78% 44.88% +8.10%
==========================================
Files 66 66
Lines 7058 7058
Branches 1541 1669 +128
==========================================
+ Hits 2596 3168 +572
+ Misses 4234 3607 -627
- Partials 228 283 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lalo
approved these changes
Mar 18, 2024
|
it's still not clear to me how this test was passing before |
nicho2
pushed a commit
to nicho2/autogen
that referenced
this pull request
Mar 21, 2024
* fix test_human_input * shorten tests * terminate chat early * limit max turns * limit max_rounds * check skip_openai
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* fix test_human_input * shorten tests * terminate chat early * limit max turns * limit max_rounds * check skip_openai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fix test failure: #2005 (comment)
Related issue number
Checks