Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issues in openai_utils.py #2062

Merged
merged 6 commits into from
Mar 19, 2024
Merged

Fix type issues in openai_utils.py #2062

merged 6 commits into from
Mar 19, 2024

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.11%. Comparing base (e23bdfb) to head (be32d60).

Files Patch % Lines
autogen/oai/openai_utils.py 76.92% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2062       +/-   ##
===========================================
+ Coverage   36.87%   56.11%   +19.24%     
===========================================
  Files          68       68               
  Lines        7067     7062        -5     
  Branches     1540     1668      +128     
===========================================
+ Hits         2606     3963     +1357     
+ Misses       4233     2765     -1468     
- Partials      228      334      +106     
Flag Coverage Δ
unittests 56.03% <76.92%> (+19.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

autogen/oai/openai_utils.py Outdated Show resolved Hide resolved
@sonichi sonichi added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit 38b64b6 Mar 19, 2024
60 of 68 checks passed
@sonichi sonichi deleted the types_oai_utils branch March 19, 2024 20:04
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Fix type issues in openai_utils.py

* fix incorrect impl

* address comment

* add to CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants