Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate separate caching docs #2054

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Related issue number

Checks

@jackgerrits jackgerrits added the documentation Improvements or additions to documentation label Mar 18, 2024
@ekzhu ekzhu requested a review from sonichi March 19, 2024 17:16
@jackgerrits jackgerrits requested review from ekzhu and gagb March 19, 2024 17:42
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.88%. Comparing base (b2be405) to head (da3451d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2054   +/-   ##
=======================================
  Coverage   36.88%   36.88%           
=======================================
  Files          68       68           
  Lines        7062     7062           
  Branches     1540     1540           
=======================================
  Hits         2605     2605           
  Misses       4228     4228           
  Partials      229      229           
Flag Coverage Δ
unittests 36.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the changes. @sonichi do you think we can move cache out of the enhanced inference use case?

@sonichi sonichi added this pull request to the merge queue Mar 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2024
@sonichi
Copy link
Contributor

sonichi commented Mar 19, 2024

Some issue with pydoc-markdown is failing the docs action for all the PRs.

@sonichi sonichi enabled auto-merge March 20, 2024 03:35
@sonichi sonichi added this pull request to the merge queue Mar 20, 2024
Merged via the queue into microsoft:main with commit 6d2c923 Mar 20, 2024
24 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Consolidate separate caching docs

* add pointer for moved

---------

Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants