Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different senders in nested chat #2028

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Allow different senders in nested chat #2028

merged 7 commits into from
Mar 15, 2024

Conversation

qingyun-wu
Copy link
Contributor

@qingyun-wu qingyun-wu commented Mar 15, 2024

Why are these changes needed?

Allow different senders in nested chat

Related issue number

#2014

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.66%. Comparing base (ea2c1b2) to head (fe7fb11).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2028       +/-   ##
===========================================
+ Coverage   37.53%   66.66%   +29.12%     
===========================================
  Files          65       65               
  Lines        6913     6915        +2     
  Branches     1521     1649      +128     
===========================================
+ Hits         2595     4610     +2015     
+ Misses       4092     1876     -2216     
- Partials      226      429      +203     
Flag Coverage Δ
unittests 66.57% <100.00%> (+29.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

notebook/agentchat_nestedchat.ipynb Outdated Show resolved Hide resolved
notebook/agentchat_nested_sequential_chat.ipynb Outdated Show resolved Hide resolved
notebook/nested_chat_1.png Outdated Show resolved Hide resolved
@sonichi sonichi added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 8844f86 Mar 15, 2024
67 checks passed
@sonichi sonichi deleted the nestedchat-enhancement branch March 16, 2024 20:34
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* allow sender in nested chat

* description

* update example list

* doc format

* meta data

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants