refactor: [conversable_agent] remove raise from property access #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raising exception seems drastic, can we return None and let the called fail in case it receives a None?
jackgerrits
reviewed
Mar 13, 2024
jackgerrits
reviewed
Mar 13, 2024
ekzhu
approved these changes
Mar 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
===========================================
+ Coverage 37.53% 47.96% +10.42%
===========================================
Files 65 65
Lines 6913 6913
Branches 1521 1648 +127
===========================================
+ Hits 2595 3316 +721
+ Misses 4092 3319 -773
- Partials 226 278 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…osoft#2006) * refactor: [conversable_agent] remove raise from property access raising exception seems drastic, can we return None and let the called fail in case it receives a None? * Update conversable_agent.py --------- Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raising exception seems drastic, can we return None and let the caller fail or handle it in case it receives a None?
Why are these changes needed?
Related issue number
Checks