-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate openai assistant related config items from llm_config #1964
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1964 +/- ##
===========================================
+ Coverage 36.99% 48.41% +11.42%
===========================================
Files 66 66
Lines 7015 7031 +16
Branches 1534 1666 +132
===========================================
+ Hits 2595 3404 +809
+ Misses 4194 3341 -853
- Partials 226 286 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
To fix the CI error, should we replace np.Inf with np.inf in the code?
|
This is fixed in the latest release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - looks like we can extend this to add the feature of utilizing OpenAI Assistants API Threads as well 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double-check my understanding, other wise looks good! great pr @IANTHEREAL
Could you make the PR from the upstream repo because we use pull_request now as the trigger for openai workflows? |
@sonichi I don't catch up with you, do you mean make a new PR using |
Yes. create a branch in microsoft/autogen and make a PR from there. Otherwise the openai test will fail. |
Why are these changes needed?
openai assistant related config in llm_config will cause some function not working, like
Related issue number
Closes #1805
Checks