code_utils.py powershell command bugfix in MacOS #1963
Conversation
|
@ekzhu could you take a look at this quickly? I'll add a PR description and fix the code formatting in the meanwhile |
ekzhu
requested review from
LittleLittleCloud and
BeibinLi
and removed request for
BeibinLi
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
===========================================
+ Coverage 36.83% 48.25% +11.42%
===========================================
Files 66 66
Lines 7058 7060 +2
Branches 1540 1669 +129
===========================================
+ Hits 2600 3407 +807
+ Misses 4232 3365 -867
- Partials 226 288 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ekzhu @jackgerrits are these changes okay to merge or should I edit or add something else? |
Need to fix the issues in the function. See my comments. |
update get_powershell_command
|
Please fix the formatting issues. |
fixed code format
Done |
|
@jackgerrits this PR is blocked by your change request. |
* macos bugfix * logs permissionerror warning only if lang is powershell command * condensed the if statements down * Update code_utils.py * fixed formatting * handled powershell_command = None case * bugfix * raising exceptions instead of logging warnings * code formatting fixed * removed return sh statement * fixed code formatting * update get_powershell_command * Update code_utils.py fixed code format --------- Co-authored-by: Eric Zhu <[email protected]>
Why are these changes needed?
Related issue number
Closes #1961
Checks