Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressible Agent require model field for llm_config #1903

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

yiranwu0
Copy link
Collaborator

@yiranwu0 yiranwu0 commented Mar 7, 2024

Why are these changes needed?

Update compression notebook to add model field to llm_config to make it runnable. Update related docs.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 46.20%. Comparing base (2503000) to head (a375c87).

❗ Current head a375c87 differs from pull request most recent head 28e4614. Consider uploading reports for the commit 28e4614 to get more accurate results

Files Patch % Lines
autogen/agentchat/contrib/compressible_agent.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1903       +/-   ##
===========================================
+ Coverage   36.13%   46.20%   +10.07%     
===========================================
  Files          63       63               
  Lines        6670     6672        +2     
  Branches     1475     1601      +126     
===========================================
+ Hits         2410     3083      +673     
+ Misses       4060     3334      -726     
- Partials      200      255       +55     
Flag Coverage Δ
unittests 46.13% <0.00%> (+10.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qingyun-wu qingyun-wu enabled auto-merge March 7, 2024 16:17
@qingyun-wu qingyun-wu added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit 1f9284c Mar 7, 2024
49 of 60 checks passed
@qingyun-wu qingyun-wu deleted the updatecompress branch March 12, 2024 23:24
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…1903)

* update

* update

* update

* update

* Update autogen/agentchat/contrib/compressible_agent.py

---------

Co-authored-by: Qingyun Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants