Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial type check CI #1882

Merged
merged 6 commits into from
Mar 9, 2024
Merged

Conversation

jackgerrits
Copy link
Member

@jackgerrits jackgerrits commented Mar 6, 2024

Why are these changes needed?

This adds an initial CI that targets known clean modules.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.09%. Comparing base (78a5a6b) to head (757b5d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1882   +/-   ##
=======================================
  Coverage   37.09%   37.09%           
=======================================
  Files          64       64           
  Lines        6834     6834           
  Branches     1502     1502           
=======================================
  Hits         2535     2535           
  Misses       4082     4082           
  Partials      217      217           
Flag Coverage Δ
unittests 37.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgerrits
Copy link
Member Author

@ekzhu @davorrunje this is ready to review

@sonichi sonichi added this pull request to the merge queue Mar 9, 2024
Merged via the queue into microsoft:main with commit 0e1a4b9 Mar 9, 2024
20 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Add type check CI

* newline

* dont install editable

* add --non-interactive

* Update type-check.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants