Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devcontainer Dockerfile for arm #1866

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Resolves a build isssue when building this on an arm device

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.03%. Comparing base (f3289cb) to head (95bc4c9).
Report is 1482 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1866   +/-   ##
=======================================
  Coverage   36.03%   36.03%           
=======================================
  Files          63       63           
  Lines        6618     6618           
  Branches     1459     1459           
=======================================
  Hits         2385     2385           
  Misses       4039     4039           
  Partials      194      194           
Flag Coverage Δ
unittests 36.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qingyun-wu qingyun-wu added this pull request to the merge queue Mar 6, 2024
Merged via the queue into microsoft:main with commit 195033e Mar 6, 2024
19 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants