-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ModelClient create function signature error #1865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CustomModelClient takes 1 positional argument but 2 were given if using **params
sonichi
requested review from
olgavrou,
davorrunje,
ekzhu,
BeibinLi,
marklysze and
LinxinS97
March 6, 2024 03:26
ekzhu
reviewed
Mar 6, 2024
olgavrou
approved these changes
Mar 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
==========================================
+ Coverage 36.10% 43.76% +7.65%
==========================================
Files 63 63
Lines 6658 6658
Branches 1470 1595 +125
==========================================
+ Hits 2404 2914 +510
+ Misses 4056 3506 -550
- Partials 198 238 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekzhu
approved these changes
Mar 6, 2024
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
CustomModelClient takes 1 positional argument but 2 were given if using **params Co-authored-by: Chi Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomModelClient takes 1 positional argument but 2 were given if using **params
Why are these changes needed?
If we define the parameters in
create
fuction of custom ModelClient class using**params
, it would throw an error like below: