-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove system message functionality from code executors #1835
Closed
jackgerrits
wants to merge
9
commits into
microsoft:main
from
jackgerrits:remove_system_message_from_code_executors
Closed
Remove system message functionality from code executors #1835
jackgerrits
wants to merge
9
commits into
microsoft:main
from
jackgerrits:remove_system_message_from_code_executors
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
==========================================
+ Coverage 37.33% 42.81% +5.47%
==========================================
Files 64 64
Lines 6913 6879 -34
Branches 1519 1646 +127
==========================================
+ Hits 2581 2945 +364
+ Misses 4109 3688 -421
- Partials 223 246 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Could you make the PR from the upstream to run the openai test? |
See PR: #1933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
@ekzhu as discussed this removes all system message functionality. We agreed that this should be solved a different way, starting with documenting how to create good system messages. Doing this now before code executors become too mature.
Related issue number
Checks