Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove system message functionality from code executors #1835

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

@ekzhu as discussed this removes all system message functionality. We agreed that this should be solved a different way, starting with documenting how to create good system messages. Doing this now before code executors become too mature.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.81%. Comparing base (b93e2c5) to head (cf1b5a6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1835      +/-   ##
==========================================
+ Coverage   37.33%   42.81%   +5.47%     
==========================================
  Files          64       64              
  Lines        6913     6879      -34     
  Branches     1519     1646     +127     
==========================================
+ Hits         2581     2945     +364     
+ Misses       4109     3688     -421     
- Partials      223      246      +23     
Flag Coverage Δ
unittests 42.69% <ø> (+5.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi
Copy link
Contributor

sonichi commented Mar 9, 2024

Could you make the PR from the upstream to run the openai test?

@jackgerrits
Copy link
Member Author

See PR: #1933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants