-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default trigger value for register_nested_chats #1833
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1833 +/- ##
===========================================
+ Coverage 35.69% 54.56% +18.86%
===========================================
Files 63 63
Lines 6625 6625
Branches 1454 1579 +125
===========================================
+ Hits 2365 3615 +1250
+ Misses 4067 2713 -1354
- Partials 193 297 +104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* remove default trigger value for register_nested_chats * update notebook and test
Why are these changes needed?
The
trigger
argument must not have default value. Because for every case it requires user to set some specific agent for thetrigger
. If it were set to any agent, then any nested chat is going to trigger a recursive nested chat.Related issue number
Checks