Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require notebooks to have all imports at top #1803

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Related issue number

Checks

@jackgerrits jackgerrits requested a review from ekzhu February 27, 2024 19:35
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.96%. Comparing base (b872789) to head (f7a6b4d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1803   +/-   ##
=======================================
  Coverage   36.96%   36.96%           
=======================================
  Files          62       62           
  Lines        6528     6528           
  Branches     1447     1447           
=======================================
  Hits         2413     2413           
  Misses       3921     3921           
  Partials      194      194           
Flag Coverage Δ
unittests 36.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekzhu ekzhu added this pull request to the merge queue Feb 27, 2024
@ekzhu ekzhu removed this pull request from the merge queue due to a manual request Feb 27, 2024
@sonichi sonichi requested a review from davorrunje February 27, 2024 23:00
@sonichi sonichi added this pull request to the merge queue Feb 27, 2024
Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Like it.

Merged via the queue into main with commit 2cf9ea4 Feb 27, 2024
22 checks passed
@sonichi sonichi deleted the jackgerrits-patch-1 branch February 27, 2024 23:55
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants