Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process message before send #1783

Merged
merged 2 commits into from
Feb 25, 2024
Merged

process message before send #1783

merged 2 commits into from
Feb 25, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Feb 25, 2024

Why are these changes needed?

  • Add a hookable method for processing a message before sending. Example application: customized frontend to display messages .
  • Renamed other hookable methods for clarity.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 48.16%. Comparing base (085bf6c) to head (9f2fea1).

Files Patch % Lines
...agentchat/contrib/capabilities/context_handling.py 0.00% 1 Missing ⚠️
...gen/agentchat/contrib/capabilities/teachability.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1783       +/-   ##
===========================================
+ Coverage   36.92%   48.16%   +11.23%     
===========================================
  Files          62       62               
  Lines        6492     6499        +7     
  Branches     1437     1561      +124     
===========================================
+ Hits         2397     3130      +733     
+ Misses       3902     3120      -782     
- Partials      193      249       +56     
Flag Coverage Δ
unittests 48.08% <89.47%> (+11.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Feb 25, 2024
Merged via the queue into main with commit 8ec1c3e Feb 25, 2024
49 of 60 checks passed
@gagb
Copy link
Collaborator

gagb commented Feb 27, 2024

This is really really useful!

@sonichi sonichi deleted the send branch February 27, 2024 19:21
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* process message before send

* rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants