-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do model check properly #1686
do model check properly #1686
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
===========================================
+ Coverage 39.50% 61.98% +22.48%
===========================================
Files 56 56
Lines 5994 5985 -9
Branches 1337 1450 +113
===========================================
+ Hits 2368 3710 +1342
+ Misses 3431 1944 -1487
- Partials 195 331 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mea culpa. Thank you for fixing my mess. I owe you one.
* do model check properly * bug in logging test * set llm_config
Why are these changes needed?
Fix test error introduced by #1654. Move model check from client to ConversableAgent, and modified corresponding tests.
Related issue number
#1522
Checks