Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1440 by applying new function registration decorator #1661

Merged
merged 10 commits into from
Feb 18, 2024
Merged

Fix issue 1440 by applying new function registration decorator #1661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5776105
Reproduce #1440
thinkall Jan 29, 2024
dca795a
Merge remote-tracking branch 'origin/main' into fix_1440
thinkall Feb 13, 2024
e906319
Updated code with latest APIs
thinkall Feb 13, 2024
b6cc6fc
Merge branch 'main' into fix_1440
thinkall Feb 13, 2024
7603f52
Reran notebook
thinkall Feb 13, 2024
b707b3b
Merge branch 'main' into fix_1440
thinkall Feb 13, 2024
13a6fbd
merge main
thinkall Feb 15, 2024
34c6000
Fix usage of cache
thinkall Feb 15, 2024
68bb265
Merge branch 'main' into fix_1440
thinkall Feb 15, 2024
2b9a930
Merge branch 'main' into fix_1440
thinkall Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion notebook/agentchat_function_call.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,12 @@
}
],
"source": [
"with Cache.disk():\n",
"with Cache.disk() as cache:\n",
" # start the conversation\n",
" user_proxy.initiate_chat(\n",
" chatbot,\n",
" message=\"Draw two agents chatting with each other with an example dialog. Don't add plt.show().\",\n",
" cache=cache,\n",
" )"
]
},
Expand Down
6 changes: 4 additions & 2 deletions notebook/agentchat_function_call_async.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,11 @@
}
],
"source": [
"with Cache.disk():\n",
"with Cache.disk() as cache:\n",
" await user_proxy.a_initiate_chat( # noqa: F704\n",
" coder,\n",
" message=\"Create a timer for 5 seconds and then a stopwatch for 5 seconds.\",\n",
" cache=cache,\n",
" )"
]
},
Expand Down Expand Up @@ -347,10 +348,11 @@
"3) when 1 and 2 are done, terminate the group chat\n",
"\"\"\"\n",
"\n",
"with Cache.disk():\n",
"with Cache.disk() as cache:\n",
" await user_proxy.a_initiate_chat( # noqa: F704\n",
" manager,\n",
" message=message,\n",
" cache=cache,\n",
" )"
]
},
Expand Down
11 changes: 6 additions & 5 deletions notebook/agentchat_function_call_currency_calculator.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,10 @@
}
],
"source": [
"with Cache.disk():\n",
"with Cache.disk() as cache:\n",
" # start the conversation\n",
" res = user_proxy.initiate_chat(\n",
" chatbot, message=\"How much is 123.45 USD in EUR?\", summary_method=\"reflection_with_llm\"\n",
" chatbot, message=\"How much is 123.45 USD in EUR?\", summary_method=\"reflection_with_llm\", cache=cache\n",
" )"
]
},
Expand Down Expand Up @@ -485,10 +485,10 @@
}
],
"source": [
"with Cache.disk():\n",
"with Cache.disk() as cache:\n",
" # start the conversation\n",
" res = user_proxy.initiate_chat(\n",
" chatbot, message=\"How much is 112.23 Euros in US Dollars?\", summary_method=\"reflection_with_llm\"\n",
" chatbot, message=\"How much is 112.23 Euros in US Dollars?\", summary_method=\"reflection_with_llm\", cache=cache\n",
" )"
]
},
Expand Down Expand Up @@ -563,11 +563,12 @@
}
],
"source": [
"with Cache.disk():\n",
"with Cache.disk() as cache:\n",
" # start the conversation\n",
" res = user_proxy.initiate_chat(\n",
" chatbot,\n",
" message=\"How much is 123.45 US Dollars in Euros?\",\n",
" cache=cache,\n",
" )"
]
},
Expand Down
Loading
Loading