Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding max_tokens to autogenstudio LLMConfig #1574

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

amihalik
Copy link
Contributor

@amihalik amihalik commented Feb 7, 2024

Why are these changes needed?

I am creating a demo using autogenstudio and writing out a dbdefaults.json. I need to set the max_tokens value and this is missing from the LLMConfig datamodel.

Related issue number

Checks

Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
In the future, it would be great to open a PR on the autogenstudio branch, following the autogenstudio contribution guide

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a2e466) 35.07% compared to head (d04df7e) 35.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1574   +/-   ##
=======================================
  Coverage   35.07%   35.07%           
=======================================
  Files          44       44           
  Lines        5323     5323           
  Branches     1234     1234           
=======================================
  Hits         1867     1867           
  Misses       3301     3301           
  Partials      155      155           
Flag Coverage Δ
unittests 35.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victordibia victordibia requested a review from sonichi February 7, 2024 19:18
@sonichi sonichi added this pull request to the merge queue Feb 7, 2024
Merged via the queue into microsoft:main with commit 7f8cfed Feb 7, 2024
18 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Adding max_tokens to autogenstudio LLMConfig

* fix formatting issue

* fix formatting issues

---------

Co-authored-by: Victor Dibia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants