Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add other language drop down link to AutoGen website #1573

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

LittleLittleCloud
Copy link
Collaborator

Why are these changes needed?

This PR adds a 'OtherLanguage' drop down link plus link to AutoGen.Net document website

image

#924

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0fa6ee) 35.19% compared to head (8deaee9) 35.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1573   +/-   ##
=======================================
  Coverage   35.19%   35.19%           
=======================================
  Files          44       44           
  Lines        5328     5328           
  Branches     1236     1236           
=======================================
  Hits         1875     1875           
  Misses       3299     3299           
  Partials      154      154           
Flag Coverage Δ
unittests 35.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LittleLittleCloud LittleLittleCloud added the dotnet issues related to AutoGen.Net label Feb 7, 2024
@ekzhu ekzhu requested a review from jackgerrits February 7, 2024 22:50
@jackgerrits
Copy link
Member

I wonder if this is the best place to expose this. I think it important to prominently link to this but I am worried about cluttering the navbar (which I am hoping to clean up soon)

@LittleLittleCloud
Copy link
Collaborator Author

I wonder if this is the best place to expose this. I think it important to prominently link to this but I am worried about cluttering the navbar (which I am hoping to clean up soon)

If the nav bar is already too crowded, how about putting it under resource tab?

aka
Resource->other languages->dotnet

Copy link
Member

@jackgerrits jackgerrits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to highlight this and we can always move it later if we need to.

@sonichi sonichi enabled auto-merge February 8, 2024 16:50
@sonichi sonichi added this pull request to the merge queue Feb 8, 2024
Merged via the queue into main with commit a3c3317 Feb 8, 2024
22 checks passed
@sonichi sonichi deleted the u/xiaoyun/0206 branch February 8, 2024 18:19
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet issues related to AutoGen.Net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants