Import oai.client directly in ConversableAgent
#1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been corrected.
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
AkashKulkarni4444
had a problem deploying
to
openai1
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1557 +/- ##
===========================================
+ Coverage 35.11% 47.19% +12.08%
===========================================
Files 43 43
Lines 5206 5206
Branches 1211 1280 +69
===========================================
+ Hits 1828 2457 +629
+ Misses 3228 2542 -686
- Partials 150 207 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ekzhu
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Just to be clear, this is not a bug, and it happens when there are potentially conflicted installations of autogen (not ours) and pyautogen. In that case it is better to purge both and install again.
We can make the change in this PR still because it is consistent with how other imports are done in the code base.
ekzhu
changed the title
oai.client directly in ConversableAgent
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
…osoft#1557) It has been corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixed
Incorrect import statement was present in conversible_agent.py.
It has been corrected.
Why are these changes needed ?
Full description provided in #1526
Related issue number
closes #1526 #1498
Reviewer
@ekzhu