-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch to graph groupchat #1555
patch to graph groupchat #1555
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
===========================================
+ Coverage 35.02% 47.19% +12.16%
===========================================
Files 43 43
Lines 5207 5206 -1
Branches 1211 1280 +69
===========================================
+ Hits 1824 2457 +633
+ Misses 3231 2542 -689
- Partials 152 207 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* patch to microsoft#1541 * graph validity test * update docstr
Why are these changes needed?
Clean up a few remaining issues in graph group chat, such as the handling of
allow_repeat_speaker
, tests, bugs.Related issue number
#1541
Checks