Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to graph groupchat #1555

Merged
merged 4 commits into from
Feb 6, 2024
Merged

patch to graph groupchat #1555

merged 4 commits into from
Feb 6, 2024

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Feb 6, 2024

Why are these changes needed?

Clean up a few remaining issues in graph group chat, such as the handling of allow_repeat_speaker, tests, bugs.

Related issue number

#1541

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f8ccf8) 35.02% compared to head (99d6a81) 47.19%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1555       +/-   ##
===========================================
+ Coverage   35.02%   47.19%   +12.16%     
===========================================
  Files          43       43               
  Lines        5207     5206        -1     
  Branches     1211     1280       +69     
===========================================
+ Hits         1824     2457      +633     
+ Misses       3231     2542      -689     
- Partials      152      207       +55     
Flag Coverage Δ
unittests 47.15% <100.00%> (+12.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@freedeaths freedeaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into main with commit 18a15d7 Feb 6, 2024
46 of 56 checks passed
@sonichi sonichi deleted the patch1541 branch February 6, 2024 15:43
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* patch to microsoft#1541

* graph validity test

* update docstr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants